Cookoff - Tweaked effects cleanup to work in dedicated environment #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger a local cleanup event
kymckay
approved these changes
Aug 15, 2022
veteran29
approved these changes
Aug 15, 2022
mharis001
approved these changes
Aug 17, 2022
RusComBear
pushed a commit
to RusComBear/ACE3
that referenced
this pull request
Dec 29, 2023
…ger a local cleanup event (acemod#9000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Previous method assumed the vehicle entity would still exist by the time the CBA global event was received by clients but in testing it becomes NULL and the local effects variables are unable to be retrieved.
Refactor switches to adding the Deleted EH on globally when a cookoff occurs and the EH triggers a local event for cleanup allowing for use of vehicle entity and access to the local effects variable stored on the vehicle.