Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload Launchers - Code cleanup #9334

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Reload Launchers - Code cleanup #9334

merged 2 commits into from
Aug 28, 2023

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 19, 2023 •
edited
Loading

When merged this pull request will:

  • Title.
  • Some changes :
    • If a launcher has two muzzles, e.g. RHS SMAW, and if the secondary muzzle were loaded but not the first, you could not use the reload action. Same happened if the launcher had a magazine in the primary muzzle with 0 ammo in it. This PR makes it so that it only checks the primary muzzle and checks if the ammo is 0.
    • The compatible magazines check did not check for magazines in magwells. This PR adds support for magwells.

The changes were included in this PR because I deemed them to be relatively small.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Aug 19, 2023
@johnb432 johnb432 mentioned this pull request Aug 20, 2023
Merged
3 tasks
LinkIsGrim
LinkIsGrim approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network sync issues aren't going to be any worse than what we currently have, IMO

@LinkIsGrim LinkIsGrim merged commit 59ee365 into acemod:master Aug 28, 2023
@johnb432 johnb432 mentioned this pull request Aug 28, 2023
Merged
3 tasks
@johnb432 johnb432 deleted the reloadlaunchers-cleanup branch January 14, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drofseh Drofseh Drofseh left review comments

@PabstMirror PabstMirror PabstMirror left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnb432 @PabstMirror @Drofseh @LinkIsGrim