Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUP Terrains Compatibility #9627

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Add CUP Terrains Compatibility #9627

merged 5 commits into from
Feb 5, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Nov 7, 2023

When merged this pull request will:

  • Merges CUP Terrains Compat from CUP to ACE.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

PabstMirror commented Nov 8, 2023

FuelStation: House_Small_F
is some kind of tank/pump combo
configs are a little trickey because we'd want to move main actions to the pump and I'm not sure we can do that (nm same as Land_Benzina_schnell)
I've never seen a map actually use this object so it's probably something we can ignore

@Mike-MF
Copy link
Member Author

Mike-MF commented Nov 8, 2023

Land_Benzina_schnell is used on Sahrani, The interaction point to start refueling is between both pumps but the actual fuel hose and nozzle come from one of the 2 available pumps.

@Mike-MF Mike-MF marked this pull request as ready for review November 14, 2023 01:05
@jonpas jonpas added this to the 3.17.0 milestone Nov 14, 2023
@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Nov 14, 2023
@acknowledge14
Copy link

Hi, Could you please also do something to CUP CWA's gas stations and vehicle maintain depots?

@Drofseh
Copy link
Contributor

Drofseh commented Jan 26, 2024

Hi, Could you please also do something to CUP CWA's gas stations and vehicle maintain depots?

CWA is not part of CUP and is developed by a different team. It would need a seperate compat.

@LinkIsGrim LinkIsGrim merged commit 5a3f3d3 into master Feb 5, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the cup_terrains_compat branch February 5, 2024 18:58
@jonpas jonpas modified the milestones: 3.17.0, 3.16.4 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants