Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUP Units Compatibility #9649

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Add CUP Units Compatibility #9649

merged 4 commits into from
Jan 20, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Nov 14, 2023 •
edited
Loading

When merged this pull request will:

  • Title, mostly ACE Hearing & No uniform restrictions
  • Not an original CUP compat, just something Me and Jonpas have used for years that's nice to have.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Mike-MF Mike-MF added this to the 3.17.0 milestone Nov 14, 2023
@Mike-MF Mike-MF added the kind/feature Release Notes: **ADDED:** label Nov 14, 2023
@jonpas jonpas mentioned this pull request Nov 14, 2023
Merged
@jonpas jonpas merged commit d8961c6 into master Jan 20, 2024
5 checks passed
@jonpas jonpas deleted the cup_units_compat branch January 20, 2024 21:29
BrettMayson pushed a commit to BrettMayson/ACE3 that referenced this pull request Jan 26, 2024
@Mike-MF @BrettMayson
Add CUP Units Compatibility (acemod#9649)
91c8bbf
@jonpas jonpas modified the milestones: 3.17.0, 3.16.4 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

@BrettMayson BrettMayson BrettMayson approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mike-MF @BrettMayson @jonpas @PabstMirror