Explosives - Add Cellphone/Detonator Keybinds #9687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ace_interact_menu_consolidateSingleChild to collapse trigger interactions for a single explosive code.
Triggers all explosives on current "active clacker", which auto-assigns to first connected clacker and is re-assignable via clacker self-interactions.
|
I'd leave defaults for detonation unbound. Alt is used for freelook and C for toggling combat pace, and both are used frequently. A "Cycle Active Detonator" keybind would be nice, as well. |
LinkIsGrim
requested changes
Dec 24, 2023
johnb432
requested changes
Dec 24, 2023
Co-Authored-By: Grim <69561145+LinkIsGrim@users.noreply.github.com> Co-Authored-By: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
LinkIsGrim
reviewed
Dec 24, 2023
|
Code LGTM, review after testing. Side-note: looking at the explosives component in general is giving me a headache. |
Done 👌🏻 |
johnb432
requested changes
Dec 26, 2023
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
|
I believe this is pretty much complete. |
|
Reviewing this without getting distracted by the rest of the explosives module is a challenge but I'll get to it. |
LinkIsGrim
previously requested changes
Feb 7, 2024
LinkIsGrim
reviewed
Feb 7, 2024
johnb432
requested changes
Feb 7, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
requested changes
Feb 7, 2024
johnb432
reviewed
Feb 7, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
reviewed
Feb 7, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add
CellphoneKeybind (unbound by default) to open the Cellphone interface;Add
Detonate All on Active DetonatorKeybind (unbound by default) to detonate all explosives tied to the currentActive Detonator;When connecting the first explosive to a detonator, that detonator will be selected as the active one, afterwards it's possible to switch the
Active Detonatoras desired via aSet Active Detonatorinteraction on any non-active detonator;Add
Cycle Active DetonatorKeybind (unbound by default) to cycle between the currently carried triggers, thereby selecting which is theActive Detonator, is visualized byCBA Notificationcommon/fnc_displayTextPicture;Only show
Detonate Allinteraction on a detonator if connected to more than 1 explosive, to allow theace_interact_menu_consolidateSingleChildsetting to consolidate that interaction;