Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Improved sorting, insignia detection, identity info verification and minor cleanup #9795

Merged
merged 12 commits into from
Feb 13, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Feb 12, 2024

When merged this pull request will:

  • Sorting now uses the previously within ACE unused lbSetTextRight.
    This does conflict with ACE Arsenal Extended, as it also uses that, however it isn't game breaking.
  • The "Empty" entry should now always be at the top. However, given the disparities between the wiki and what I found, I'm not sure if this is guaranteed to always be true.
  • Arsenal - Left panel code improvements #9787 improved insignia source detection (mission, campaign or config). This PR adds those changes to sorting and the item info which is displayed in the bottom right.
  • Added GVAR(currentInsignia) to the list of insignia to display, so that if the insignia you have is not present in the arsenal, it won't disappear. It's not a very robust or elegant solution, as if you unselect the insignia that's unavailable in the arsenal and change tabs, it will lose the insignia. However, losing an insignia is far less important than losing actual gear, so for now this ought to do, as it's a very easy solution.
  • Removed an unnecessary file and adjusted a header and comment in FUNC(addListBoxItem).
  • Made saving in loadouts be config case sensitive.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should notify ACEAX's author about this before release

addons/arsenal/functions/fnc_fillLeftPanel.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim added this to the 3.16.4 milestone Feb 12, 2024
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Feb 12, 2024
johnb432 and others added 2 commits February 12, 2024 15:41
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim
Copy link
Contributor

I've added removal of missing extended info for face/voice/insignia as well as logging, plus passed the relevant arrays to the event so third party can modify them as well.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack of arrayIntersect was intentional in case duplicates were added during event handling

addons/arsenal/functions/fnc_verifyLoadout.sqf Outdated Show resolved Hide resolved
addons/arsenal/functions/fnc_verifyLoadout.sqf Outdated Show resolved Hide resolved
johnb432 and others added 2 commits February 13, 2024 11:13
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim LinkIsGrim changed the title Arsenal - Improved sorting, better insignia detection and minor cleanup Arsenal - Improved sorting, insignia detection, identity info verification and minor cleanup Feb 13, 2024
@johnb432 johnb432 merged commit fd5e56f into master Feb 13, 2024
5 checks passed
@johnb432 johnb432 deleted the arsenal-sort branch February 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants