-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arsenal - Improved sorting, insignia detection, identity info verification and minor cleanup #9795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should notify ACEAX's author about this before release
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
I've added removal of missing extended info for face/voice/insignia as well as logging, plus passed the relevant arrays to the event so third party can modify them as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lack of arrayIntersect was intentional in case duplicates were added during event handling
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
When merged this pull request will:
lbSetTextRight
.This does conflict with ACE Arsenal Extended, as it also uses that, however it isn't game breaking.
GVAR(currentInsignia)
to the list of insignia to display, so that if the insignia you have is not present in the arsenal, it won't disappear. It's not a very robust or elegant solution, as if you unselect the insignia that's unavailable in the arsenal and change tabs, it will lose the insignia. However, losing an insignia is far less important than losing actual gear, so for now this ought to do, as it's a very easy solution.FUNC(addListBoxItem)
.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.