Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPE Compat - Fix flamethrower magazines not showing in arsenal / 50 Cal deafness #9803

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

kerckasha
Copy link
Contributor

When merged this pull request will:

  • Fixes flamethrower magazines not appearing in ace arsenal
  • Sets ACE_Caliber on SPE 50 cal ammo to put it more in line with vanilla ammo when it comes to causing deafness (Without it earplugs were ineffective)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

does flamethrower mag show in vanilla arsenal?

@kerckasha
Copy link
Contributor Author

does flamethrower mag show in vanilla arsenal?

Yeah - the reason it doesn't show in the ace arsenal is it currently is using

		type = "12 * 256";

Which is some old value that isn't used anymore - and is filtered by ace arsenal as it doesn't fall into the 'used' types

kerckasha and others added 2 commits February 26, 2024 12:02
addons/compat_spe/CfgAmmo/bullets.hpp Outdated Show resolved Hide resolved
addons/compat_spe/CfgMagazines/flamethrower.hpp Outdated Show resolved Hide resolved
kerckasha and others added 2 commits February 27, 2024 11:55
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@johnb432 johnb432 merged commit bfbfc66 into acemod:master Feb 28, 2024
5 checks passed
@johnb432 johnb432 added this to the 3.17.0 milestone Feb 28, 2024
@kerckasha kerckasha deleted the SPE_Compat_magazineFixes branch February 28, 2024 17:36
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants