Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather - More permissive wind info indicator + auto-enabling when throwing grenades #9820

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Mar 3, 2024

When merged this pull request will:

  • Make Wind Info indication more permissible, by preventing it from being disabled when looking at the map, carrying, dragging or entering a vehicle (useful for mortar/turret windage correction);
  • Temporarily enable Wind Info while in the Advanced Throwing interface, to aid in placing smoke grenades effectively;

addons/advanced_throwing/functions/fnc_prepare.sqf Outdated Show resolved Hide resolved
addons/weather/XEH_postInit.sqf Show resolved Hide resolved
@mrschick
Copy link
Contributor Author

mrschick commented Mar 4, 2024

It seems that Static Weapons cause the player's eyePos to not get any wind, despite being open. Meanwhile some APC passengers do get accurate wind despite being in a closed compartment.
How could that be fixed?

Co-Authored-By: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-Authored-By: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim
Copy link
Contributor

It seems that Static Weapons cause the player's eyePos to not get any wind, despite being open. Meanwhile some APC passengers do get accurate wind despite being in a closed compartment. How could that be fixed?

I guess for static weapons we could add an offset to eyePos height, should be good enough, if a bit of a hack.

@mrschick
Copy link
Contributor Author

mrschick commented Mar 6, 2024

Neat idea, I guess a quick (eyePos ACE_Player) vectorAdd [0, 0, 2];, should do the trick.

@mrschick
Copy link
Contributor Author

mrschick commented Mar 6, 2024

1m offset works like a charm on turrets, including RHS USAF+AFRF ones.

@LinkIsGrim LinkIsGrim added kind/change Release Notes: **CHANGED:** kind/enhancement Release Notes: **IMPROVED:** labels Mar 26, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.0 milestone Mar 26, 2024
@LinkIsGrim
Copy link
Contributor

TODO: cleanup changelog

@LinkIsGrim LinkIsGrim merged commit c88e1ab into acemod:master Mar 26, 2024
5 checks passed
@mrschick mrschick deleted the feature/persistent-wind-info branch March 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Release Notes: **CHANGED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants