Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless - Code optimisation #9873

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Headless - Code optimisation #9873

merged 7 commits into from
Apr 4, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Made some CBA settings no longer require restarting, because they actually didn't need a restart to apply.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the ignore-changelog Release Notes: Excluded label Mar 24, 2024
jonpas
jonpas reviewed Mar 24, 2024
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes otherwise!

addons/headless/functions/fnc_handleSpawn.sqf Outdated Show resolved Hide resolved
@jonpas jonpas changed the title Headless - Various minor code optimisations Headless - Code optimisation Mar 24, 2024
@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** and removed ignore-changelog Release Notes: Excluded labels Mar 24, 2024
@johnb432 johnb432 mentioned this pull request Mar 25, 2024
Merged
1 task
LinkIsGrim
LinkIsGrim reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

addons/headless/functions/fnc_transferGroups.sqf Outdated Show resolved Hide resolved
addons/headless/functions/fnc_transferGroups.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Mar 26, 2024
johnb432 and others added 4 commits April 1, 2024 04:24
@johnb432 @LinkIsGrim
Update addons/headless/functions/fnc_transferGroups.sqf
2f5e97c 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@johnb432 @LinkIsGrim
Update addons/headless/functions/fnc_transferGroups.sqf
5257ad3 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@johnb432
Update fnc_transferGroups.sqf
5362a1f
@johnb432
Merge branch 'master' into headless-optimisations
337a59d
@LinkIsGrim LinkIsGrim merged commit 0d401b2 into master Apr 4, 2024
5 checks passed
@johnb432 johnb432 deleted the headless-optimisations branch April 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

@rautamiekka rautamiekka rautamiekka left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.17.1
Development

Successfully merging this pull request may close these issues.
4 participants
@johnb432 @rautamiekka @jonpas @LinkIsGrim