Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction - Make magazine passing animation optional #9875

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

ZluskeN
Copy link
Contributor

@ZluskeN ZluskeN commented Mar 25, 2024

When merged this pull request will:

  • Add optional _animate parameter
  • Change to removing the magazine from _player using CBA_fnc_removeMagazine

_animate is optional and the Default is true so should not break anything. Function can then be used for tossing magazines and the like.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@ZluskeN ZluskeN changed the title Interaction - Make animation optional and use CBA_fnc_removeMagazine Interaction - Make magazine passing animation optional Mar 25, 2024
@PabstMirror PabstMirror added this to the 3.17.0 milestone Mar 25, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 25, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim merged commit 5ca81b7 into acemod:master Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants