Interact Menu - Use hashmaps for interactions #9920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
reviewed
Apr 4, 2024
LinkIsGrim
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Not public so it doesn't matter, but this does have some 3rd party use and will become case-sensitive
LinkIsGrim
reviewed
Apr 4, 2024
LinkIsGrim
reviewed
Apr 4, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
approved these changes
Apr 4, 2024
|
|
||
| // Compile actions for CAManBase now and use for all mans types | ||
| ["CAManBase"] call FUNC(compileMenu); | ||
| GVAR(cacheManActions) = +(GVAR(ActNamespace) getVariable ["CAManBase", []]); // copy | ||
| GVAR(cacheManActions) = +(GVAR(ActNamespace) getOrDefault ["CAManBase" call EFUNC(common,getConfigName), []]); // copy |
There was a problem hiding this comment.
Better safe than sorry, I guess
There was a problem hiding this comment.
Yea, in case, somehow, a mod managed to change it - highly unlikely, so we could probably remove it.
PabstMirror
reviewed
Apr 6, 2024
PabstMirror
reviewed
Apr 6, 2024
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Use hashmaps for interactions * Update addons/interact_menu/functions/fnc_splitPath.sqf Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com> * Account for case sensitivity * Update addons/interact_menu/functions/fnc_compileMenu.sqf Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Update addons/interact_menu/functions/fnc_compileMenuSelfAction.sqf Co-authored-by: PabstMirror <pabstmirror@gmail.com> --------- Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ACE_interact_menu_fnc_splitPath.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.