Fire - Add fire damage to wrecks #9962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Apr 20, 2024
How long of a time difference? If it's less than 30s, doesn't matter IMO |
PabstMirror
reviewed
Nov 15, 2024
PabstMirror
reviewed
Nov 15, 2024
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
johnb432
commented
Nov 16, 2024
It's just about 30s. |
Acceptable IMO. |
LinkIsGrim
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Title.
Requires Fire - Mini-Rewrite #9757.
Works in SP. Unfortunately,
_object getEntityInfo 13returnstruefor both smoke and fire effects (fire effects die out before the smoke does). The time difference is not long, but it's not as good as I had hoped. Thoughts?Test in MP
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.