Update README.md #37
Closed
Update README.md #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,12 @@ To open DICAT, simply double click on the executable. | |||
|
|
|||
| To install DICAT source code on a computer, download and save the content of the current Github repository into a workstation. | |||
|
|
|||
| Before running DICAT, make sure your systems contains a [Python](https://www.python.org) compiler with the [TkInter](https://wiki.python.org/moin/TkInter) library (usually, TkInter comes by default with most Python installations. The [PyDICOM](http://www.pydicom.org) package is also required by DICAT. | |||
| Before running DICAT, make sure your systems contains a [Python](https://www.python.org) compiler with the [TkInter](https://wiki.python.org/moin/TkInter) library (usually, TkInter comes by default with most Python installations. | |||
There was a problem hiding this comment.
missing a closing parenthesis after installations.
|
This is great! Thank you!! :) I just had two tiny comments to take care but other than that (typo and some more precision). |
updated the documentation for clarity.
| @@ -40,7 +40,12 @@ To open DICAT, simply double click on the executable. | |||
|
|
|||
| To install DICAT source code on a computer, download and save the content of the current Github repository into a workstation. | |||
|
|
|||
| Before running DICAT, make sure your systems contains a [Python](https://www.python.org) compiler with the [TkInter](https://wiki.python.org/moin/TkInter) library (usually, TkInter comes by default with most Python installations. The [PyDICOM](http://www.pydicom.org) package is also required by DICAT. | |||
| Before running DICAT, make sure your systems contains a [Python](https://www.python.org) compiler with the [TkInter](https://wiki.python.org/moin/TkInter) library (usually, TkInter comes by default with most Python installations.) | |||
There was a problem hiding this comment.
Sorry... I am being picky but the ")" should be between installations and the dot.
period now outside the parenthesis.
|
@gluneau Sorry. I just realized, could you send the pull request to the branch 2.1-dev instead of master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to install this package for the requirements to be fulfilled.