Add PHP 8.1 Support #7989
Merged
Add PHP 8.1 Support #7989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
PHP81
branch
2 times, most recently
from
d1042e1
to
75f0782
Compare
driusan
force-pushed
the
PHP81
branch
28 times, most recently
from
de27a91
to
3f66bda
Compare
execute is returning "NULL" on PHP 8.0 and "false" on PHP 8.1, causing 8.1 to fail. This explicitly sets the value to null so that both versions have the same behaviour in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the loading of the main LORIS pages with PHP 8.1.
Between 8.0 and 8.1 the behaviour of the PDO changed so that database selects are typed according to the column, while previously they were always a string. This restores the behaviour of 8.0 by always casting them with strval to avoid fatal type errors.
Some signatures for jsonSerialize also had to be modified to prevent warnings and phpstan had to be upgraded. The dashboard and a few random pages now load, but I haven't tested this extensively.
Blocked by #7987