Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard][Study Progression] Add tooltip visualising of Total in line chart #8123

Merged
merged 8 commits into from
Sep 6, 2022
Merged

[dashboard][Study Progression] Add tooltip visualising of Total in line chart #8123

merged 8 commits into from
Sep 6, 2022

Conversation

satvik-tha-god
Copy link
Contributor

Brief summary of changes

  • Added total scan and recruitment data in their respective chart visualisations
  • Added total calculation
  • Updated related CSS
  • Updated scale of chart appropriately
  • Minor Spelling mistake fixes

Testing instructions (if applicable)

  1. Check the dashboards for Study Progression Data

Link(s) to related issue(s)

Here's how the changes look:
Screenshot from 2022-06-17 19-50-35
Screenshot from 2022-06-17 21-12-21

@racostas racostas self-requested a review July 24, 2022 17:57
racostas
racostas requested changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change. Let's please put the CSS modifications inside the module itself.
/modules/statistics/css/recruitment.css

racostas
racostas approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two extra lines that could be removed from the .css file. Not sure why the automated test continue failing, but doesn't seem to be related to this PR.

modules/statistics/css/recruitment.css Outdated Show resolved Hide resolved
satvik-tha-god and others added 4 commits August 2, 2022 12:35
@satvik-tha-god @racostas
[dashboard] Update recruitment.css removed line
db9945c 
Co-authored-by: racostas <37309344+racostas@users.noreply.github.com>
@satvik-tha-god @racostas
[dahsboard] Update recruitment.css removed line
f1d2d70 
Co-authored-by: racostas <37309344+racostas@users.noreply.github.com>
@satvik-tha-god
Merge branch 'aces:main' into 2022_06_17_study_progression_total
d9d5c7e
@satvik-tha-god
retrigger checks
060c21a
@racostas racostas self-requested a review August 22, 2022 17:41
racostas
racostas approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed. LGTM.

@racostas racostas added GSOC Google Summer of Code related Passed Manual Tests PR has undergone proper testing by at least one peer labels Aug 22, 2022
@driusan driusan merged commit 7c1d2e8 into aces:main Sep 6, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racostas racostas racostas approved these changes

Assignees
No one assigned
Labels
GSOC Google Summer of Code related Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.

[dashboard / Study Progression] To show total of recruitments per day
4 participants
@satvik-tha-god @racostas @driusan @ridz1208