Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mri_violations] Add new mri_protocol fields to "Could not identify scan type" page #8156

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Aug 23, 2022

Brief summary of changes

This adds the image_type, PhaseEncodingDirection and EchoNumber to the tables displayed under the page displayed after clicking on "Could not identify scan type" link in the main page.

Testing instructions (if applicable)

  1. check out this branch
  2. go to the MRI violation module and click on one of the "Could not identify scan type" link present in the violation table. That will redirect you to the page with the list of MRI protocol and list of fields for the violated scans. Ensure that there are image_type, PhaseEncodingDirection and EchoNumber (note: sometimes those fields will be empty if there is not restriction on the mri_protocol table for those fields or if the violated scan does not contain a PhaseEncodingDirection or multiple EchoNumber

Note: make sure to run the SQL patches that affect the MRI tables in the new patch directory

Link(s) to related issue(s)

@cmadjar cmadjar added the Feature PR or issue introducing/requiring at least one new feature label Aug 23, 2022
Copy link
Contributor

@nicolasbrossard nicolasbrossard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested on my VM and it works perfectly. 👍

@driusan driusan merged commit 48db09a into aces:24.1-release Sep 21, 2022
@nicolasbrossard nicolasbrossard added the Passed Manual Tests PR has undergone proper testing by at least one peer label Sep 22, 2022
@ridz1208 ridz1208 added this to the 24.1.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR or issue introducing/requiring at least one new feature Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants