Flag_Status field in flag table appears to be unused

[GeorgeMurad]

• Create new patch file under SQL/New_patches to Drop the unused Flag_status field under flag table.

• Remove the Flag_status SQL/0000-00-00-schema.sql file.

• Remove the Flag_status field from

  Loris/test/unittests/NDB_BVL_Instrument_Test.php

  Line 1150 in fa666f5

  'Flag_status' => null,

  file.

1. Issue: flag table's Flag_Status appears to be unused #8254

[driusan]

Since it's dropping a column that might have data and existing projects might not want to run it should go in cleanup patches (which need to be manually run after review) instead of new_patches (which get concatenated and into one big release patch)

[GeorgeMurad]

Okay I will drop it under the cleanup patches then!

[driusan]

Should this update raisinbread too?

[GeorgeMurad]

@driusan I haven't seen any Flag_status field under raisinbread!

[driusan]

You're dropping a column from the flag table so I assume the raisinbread flag table has data for it?

[GeorgeMurad]

@driusan I am not sure, I have checked it and can't see any Flag_status related to raisinbread!

[driusan]

It's in https://github.com/aces/Loris/blob/main/raisinbread/RB_files/RB_flag.sql.

I'm not sure what the preferred way to update it is, maybe @ridz1208 knows.

[GeorgeMurad]

@ridz1208 What's your opinin for updating the Flag_status on https://raw.githubusercontent.com/aces/Loris/main/raisinbread/RB_files/RB_flag.sql ?

[ridz1208]

@GeorgeMurad last I checked there was a tools/exporters/db_data...(something)...php that will dump your current DB into the raisinbread directory. so basically, if you source RB, run your patch on it and run the tool script. you should see that the RB_flag.sql file has changed (sometimes other files change for whitespacing and stuff you can ignore those)

but yeah that should do it for you

[driusan]

@kongtiaowang I think your change looks like it's done in the last commit. Can you review and if it looks good assign to me to merge?

[kongtiaowang]

Hi @driusan this PR is ready for your to merge.

[driusan]

@GeorgeMurad This needs to be rebased before I can merge it to make sure the required tests pass.