Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form.js] Add DateTimeElement wrapper #8410

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Form.js] Add DateTimeElement wrapper #8410

merged 1 commit into from
Mar 17, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Feb 24, 2023

This adds a DateTimeElement wrapper to our form classes for use cases where a datetime needs to be selected. It is a wrapper around the datetime-local input type.

@driusan
[Form.js] Add DateTimeElement wrapper
fbf0014 
This adds a DateTimeElement wrapper to our form classes for use
cases where a datetime needs to be selected. It is a wrapper
around the datetime-local input type.
@driusan driusan added UI PR or issue introducing/requiring improvements to the LORIS User Interface javascript Pull requests that update Javascript code Feature PR or issue introducing/requiring at least one new feature and removed UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Feb 24, 2023
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@laemtl laemtl self-assigned this Mar 7, 2023
@laemtl laemtl assigned jeffersoncasimir and unassigned laemtl Mar 14, 2023
jeffersoncasimir
jeffersoncasimir approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and as intended!

@jeffersoncasimir jeffersoncasimir added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 16, 2023
@driusan driusan merged commit 8d03992 into aces:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersoncasimir jeffersoncasimir jeffersoncasimir approved these changes

Assignees

@jeffersoncasimir jeffersoncasimir

Labels
Feature PR or issue introducing/requiring at least one new feature javascript Pull requests that update Javascript code Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@driusan @jeffersoncasimir @laemtl