-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Remove Database::singleton function #8427
Conversation
docs/instruments/NDB_BVL_Instrument_UPLOADER_TEMPLATE.class.inc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than the couple comments
@kongtiaowang it seems like some unit tests can't connect to the database but the log has the credentials and it's consistently the same tests.. do you have any ideas? |
@ridz1208 getting the tests to pass took more significant changes than expected, can you re-review? |
There are currently 3 methods of getting a reference to a database in LORIS, in order of preference:
The only reference to 3 left is in the implementation of option 2. This removes the Database::singleton by inlineing the reference into the factory and removes all remaining references to Database::singleton (mostly from documentation and a couple unit tests.)