-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue_tracker - raisinbread/tools] Fix issue tracker history wrong module ID #8677
[issue_tracker - raisinbread/tools] Fix issue tracker history wrong module ID #8677
Conversation
@driusan curious for you to take a look at this. @LeighMac @sruthymathew123 @nicolasbrossard wasn't sure who to tag, but wondering if IBIS has this issue too post upgrade |
I removed fixes to the tool script The SQL patch alone can be run on 24.1 + to sufficiently fix the issues_history modules ID mappings left behind by the single use tool script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tested:
22 > 23 upgrade + tools/single_use/Convert_LorisMenuID_to_ModuleID.php script > 24 upgrade + this PR patch
24.1-release > make testdata + patch
This PR checkout > make testdata
All 3 cases apply the same changes in the issues_history
table.
Brief summary of changes
This single use tool https://github.com/aces/Loris/blob/main/tools/single_use/Convert_LorisMenuID_to_ModuleID.php failed to convert the now deprecated LorisMenuID to the current modules table ModuleID for rows in issues_history table. The histories now refer to old LorisMenuIDs which map to the wrong module in the new modules table. This PR fixes this discrepancy by providing a patch, fixing the raisinbread dataset
, and updating the conversion tool.How this PR should be used for existing projects:
If project upgraded to 23.0 and so already ran the Convert_LorisMenuID_to_ModuleID.php script, the project should run the patch
SQL/New_patches/2023-04-25-FixIssueWrongModuleID.sql
If the project needs to upgrade to 23.0, the project should run this now fixed single use scriptConvert_LorisMenuID_to_ModuleID.php
Have you updated related documentation?
Testing instructions (if applicable)
Link(s) to related issue(s)