[instrument & instrument_manager] test plans update

modules/instrument_manager/test/TestPlan.md

@@ -21,4 +21,5 @@ Check that function CheckTable performs the appropriate checks (catches these di
 eg "Table Valid" column is valid when instrument fields match up and "Pages Valid" is valid when subpages are valid.
    [Manual Testing]
 9. With a user who has the `instrument_manager_write` permission, click the button in the `Permission Required` column. A modal should popup where you can edit the permissions.
-Check that modifying the permissions saves the new permissions.
+   - Check that modifying the permissions saves the new permissions.
+   - Check that a user can access that instruments if and only if they has that permission.

modules/instruments/test/TestPlan.md

@@ -26,14 +26,7 @@ has the 'Send to DCC' (_"Send to DCC"_) permission, and the configuration `Instr
 'Candidate Age at Death (Months)' instead of 'Candidate Age (Months)'. To set the `postMortem` variable
 for PHP instruments, assign the variable within the instrument's PHP class; for LINST instruments,
 include `postmortem{@}true` in the instrument's meta file.
-9. Check that access restriction in `config.xml` works.
- - In the `<instrumentPermissions>` section of `config.xml`
- - set the `<useInstrumentPermissions>` to `true`
- - add the name of an instrument in the `<Test_name>` tag of the `<instrument>`
- - add the name of a permission in the `<permission>` tag of the same `<instrument>`
-   - create a new permission if needed (`permissions` table)
- - check that the user can access that instruments if and only if they has that permission
-10. Test both LINST & PHP instruments found in the `project/instruments` directory.
+9.  Test both LINST & PHP instruments found in the `project/instruments` directory.
     - Refer to the following guides for help.
         1. The [Instrument Insertion](https://github.com/aces/Loris/wiki/Instrument-Insertion) for PHP instruments.
         2. The [Creating and installing clinical instruments](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links) for LINST instruments.
@@ -42,7 +35,7 @@ include `postmortem{@}true` in the instrument's meta file.
         2. Create a timepoint
         3. Start its visit stage
         4. Enter sample data, testing each field's type and logic constraints
-11. Verify Validity flags are functioning for instruments.
+10.  Verify Validity flags are functioning for instruments.
     - **Validity:** can be marked as “Valid”, “Questionable”, or “Invalid”. Whether or not this flag is shown for an instrument is by the boolean $ValidityEnabled. Whether the field is required before flagging an instrument as complete is determined by $ValidityRequired.
     - You can test the forgoing flags by switching the corresponding boolean of the test instruments to either `true` or `false`.