[tools] Fix efficiency of fix_candidate_age script #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the problem you're trying to solve is efficiency can you also update it to use bulkLoadInstanceData rather than calling factory n times? I think that would also be a (potentially much bigger) improvement in the efficiency. |
Thanks Dave, done! |
driusan
approved these changes
Dec 1, 2023
driusan
pushed a commit
that referenced
this pull request
Jan 23, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes #8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on #8998 (file modifications in common and done at a later time).
jeffersoncasimir
added a commit
to jeffersoncasimir/Loris
that referenced
this pull request
Feb 29, 2024
This resolves the data shift issue by adding the number of valid samples in the last chunk to the index.json, and using it for the calculations which previously assumed all chunks were filled. Closes aces#8992. Has a Loris-MRI counterpart: aces/Loris-MRI#1030 Loosely dependant on aces#8998 (file modifications in common and done at a later time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes a bug in the fix_candidate_age.php script where it is getting CommentIDs from every instrument for each instrument, instead of just getting commentIDs for that instrument. This is making the script take n times as long where n = the number of instruments on the project.
Testing instructions (if applicable)