Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[statistics] bug fix - projectID issue #9170

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Mar 27, 2024

fix issue
#9137
[CRITICAL] /var/www/Loris/php/libraries/User.class.inc:476: Uncaught TypeError: User::hasProject(): Argument #1 ($projectID) must be of type ProjectID, string given, called in /var/www/Loris/modules/statistics/php/statistics_site.class.inc on line 134 and defined in /var/www/Loris/php/libraries/User.class.inc:476
Bug
https://test-dev-260.loris.ca/statistics/statistics_site/?CenterID=2&ProjectID=1

@kongtiaowang kongtiaowang added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Mar 27, 2024
@regisoc regisoc self-assigned this Mar 28, 2024
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on my vm, when a project is selected, no 500 error is generated and redirection is working.

@driusan driusan merged commit 053dff6 into aces:main Apr 4, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants