Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publication] Fix deletion of file when editing project #9181

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Mar 28, 2024

Brief summary of changes

In this PR the deleteUpload function of ProjectFormFields class in projectFields.js is fixed by changing the syntax of the swal.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Propose a project with a file
  2. Edit that project and attempt to delete the file.
  3. When you click the X next to the file, a swal should show up.
  4. If you click "No, cancel it" in the swal, make sure that the file is kept.
  5. If you click "Yes, I am sure" in the swal, make sure that the file is removed.

Link(s) to related issue(s)

@sruthymathew123 sruthymathew123 self-assigned this Apr 4, 2024
@sruthymathew123 sruthymathew123 added the Passed Manual Tests PR has undergone proper testing by at least one peer label Apr 4, 2024
@sruthymathew123
Copy link
Contributor

All the testing instructions are followed and works as expected!

@sruthymathew123
Copy link
Contributor

@driusan This is good to go.

@driusan driusan merged commit dbe6e69 into aces:main Apr 4, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[publication] Front-end error on file deletion
4 participants