[create_timepoint] Fix type errors in timepoint creation #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorisForm returns values as strings, but \ProjectID::singleton and \CenterID::singleton take integer values. This updates the singleton calls to cast as an int to fix the type errors on timepoint creation.
skarya22
requested changes
Sep 25, 2024
Comment on lines
238
to
239
| ? \CenterID::singleton(intval($values['psc'])) | ||
| : null; |
There was a problem hiding this comment.
Can you indent these two lines?
There was a problem hiding this comment.
This indentation came from npm run lintfix:php.. I just tried to manually indent it and it looks like PHPCS doesn't complain, so sure.
skarya22
added
the
Needs Work
driusan
removed
the
Needs Work
|
Created #9362 for the tests issue. |
skarya22
added
the
Passed Manual Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LorisForm returns values as strings, but \ProjectID::singleton and \CenterID::singleton take integer values. This updates the singleton calls to cast as an int to fix the type errors on timepoint creation.
Fixes #9357