Catch 2 v3 #78
Draft
Catch 2 v3 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch2 has a number of issues with ASAN, compile times, etc. doctest is much faster and simpler. There are a couple of tests that need to be rewritten, and have been commented out.
Update vcpkgGitCommitId: 2e781b513f486618909d9f78185c0c7ebb54624c
Mostly to try to see if we can get less output from ASAN.
Update vcpkgGitCommitId: 840f701d83d5019aa5033c9d9d08a4cc0d0ebdce which should fix spdlog.
Also take advantage of std::numbers in C++20.
Should rename functions to be consistent.
Geometry3 -> Geometry_3 FoliatedTriangulation3 -> Foliated_Triangulation_3 etc. New function incident_cells_from_edge to encapsulate all the logic behind finding locations for bistellar flips based on the number of incident cells (ie. == 4). Updated to vcpkgGitCommitId: c379c64ff9ec1b8c6100ebff8e81ecdcb49b330c
Only need a reference to the triangulation, the edge to be flipped, and the top and bottom vertices. Update vcpkgGitCommitId: 1323f4b83d6a91e415e9ce06a45c9d0a6473aaf2 The function still needs to be debugged, of course.
Turn on doctest fast assertions. Fix references to Catch in documentation and CI. Use doctest test suites. Update CI to use vcpkgGitCommitId: 9e8da9bd8aa16fb268ac68f731c44fdef5fec1ab
PVS Studio identified possible use of an uninitialized value obtained by a function returning a std::optional<T>.
# ---------------------------------------------------------- # Header - (type): Brief description # ---------------------------------------------------------- # * feature A new feature # * fix A bug fix # * docs Changes to documentation only # * style Style/format changes (whitespace, etc.) # * refactor Changes not related to a bug or feature # * performance Changes that affects performance # * test Changes that add/modify/correct tests # * build Changes to build system (configs, etc.) # * ci Changes to CI pipeline/workflow # ---------------------------------------------------------- # ---------------------------------------------------------- # Body - More detailed description, if necessary # ---------------------------------------------------------- # * Motivation behind changes, more detail into how # functionality might be affected, etc. # ---------------------------------------------------------- # ---------------------------------------------------------- # Footer - Associated issues, PRs, etc. # ---------------------------------------------------------- # * Ex: Resolves Issue #207, see PR #15, etc. # ----------------------------------------------------------
fmt::print doesn't like CGAL point << output anymore, so wrap it with a point_to_str that converts it. Fix Metropolis to use SystemError.what() which is a const string for reporting via spdlog::trace which uses fmt which requires const string arguments. Similar conversions using Gmpzf.to_double to make spdlg::debug happy. Update vcpkgGitCommitId: 23cc58477e200bb54c293ad76f3ce438dbabc86c
Nice catch via sonarcloud. Also remove unused includes.
Found a few more places to fix fmt. Simplified try_32_move. Removed diagnostic code that was throwing exceptions. That info gets printed out before the runs already. Updated vcpkgGitCommitId: 5fb8f6c24ec13a36db460a555b24b20be03bd73c
Except the usual transparent functors 'less<>' issue which is unfixable given docopt.cpp's current implementation.
Consistent formatting
Via vcpkgGitCommitId: 316323019266ff54be39e0cb2c2de9caaa94cf75
vcpkgGitCommitId: 01b29f6d8212bc845da64773b18665d682f5ab66
Also update packages to vcpkgGitCommitId: 929fc61671bb5e5e7322981dce1153abf24f54cf And re-enable Windows builds on GHA.
Update GitHub Actions with vcpkgGitCommitId: 57ae838ee87313a3f0c5e14b008767d97d94debe Start slow with iwyu to ensure it's correct on all platforms.
Update Travis-CI build environment to Jammy with gcc-11 and clang-14.
GHA should all pass now
Update GitHub Actions to vcpkgGitCommitId: bdf073a835ebea07e1d039cd9cff4f650014e4ce
Jammy doesn't have clang-15 yet. vcpkgGitCommitId: ec7216c8e1206580ccec7a33024ef38216efdaf8
vcpkgGitCommitId: 7e7c62d863b1bf599c1d104b76cd8b74475844d4
And GitHub Action for Windows.
Also fix GHA for Windows.
Import current version of bistellar flip from https://github.com/acgetchell/bistellar-flip This mostly works except for setting neighboring cells correctly. Update all tests accordingly. Remove lots of dead code, including src/bistellar.cpp. Update GHA to vcpkgGitCommitId: 783e2d8e9983a74fad1b9d7b1d88a020438d32b2
Also update version of vcpkg to c8696863d371ab7f46e213d8f5ca923c4aef2a00 in repo
For running on HPC
Small fixes in bistellar-flip.cpp. This commit is to document a compile-time bug with vcpkg's CGAL port with the qt feature enabled.
They also got rid of the annoying difference where the Linux library was oddly named 'docopt_s' and the Windows library was the more sensible 'docopt'. So I can collapse my cmake file.
Windows and macOS builds and links to docopt library, Linux links to docopt_s.
More checks run on pull requests. Switch to using M1 macOS runner.
Fix clang-format changes. Go back down to the free tier for macOS. Update code-ql action.
Docopt isn't being maintained anymore, has long-standing reported bugs, and generates different linker targets depending on platform. In particular, building for HPC was getting to be a pain. This explores using boost::program_options, since I already need Boost for CGAL.
Enable macOS builds on all pull requests. Add linker target for boost::program_options on Linux.
Add usage message back to initialize. Swap out docopt for boost::program_options on cdt executable.
Also remove docopt from vcpkg.
Remove references to docopt and update help screen.
Fix SonarCloud, remove building on macOS until fontconfig issue resolved.
The error message indicates that the Clang compiler does not recognize the `/utf-8` option, which is a Microsoft Visual C++ (MSVC) specific option. To resolve this issue, you need to conditionally add the `/utf-8` flag only when using the MSVC compiler. Here's how you can modify your `CMakeLists.txt` to conditionally add the `/utf-8` flag: 1. Check if the compiler is MSVC. 2. If it is, add the `/utf-8` flag.
* Make separate branch for C++23 * Fix merge errors from develop * ci: update to clang-18 via pkgx This should resolve the build failure for updating to C++23. clang-17 didn't support std::expected, but clang-18 should. * ci: Fix checking twice on PRs and pushes * ci: Fix Travis and AppVeyor * ci: Fix clang on Travis-CI * ci: Don't double build PR pushes on Travis-CI
* ci: Fix appveyor * ci: Fix pkgx windows error * ci: pkgx fixes [skip ci] * ci: Updates [skip ci] * ci: Allow clang-format to run by request [skip ci] * fix: strip out qt temporarily Until we can get it to compile again * fix: CoderabbitAI suggestions * fix: Coderabbit suggestions part 2 * fix: More Coderabbit tuning * fix: AppleClang C++23 support check left out AppleClang * Update src/bistellar-flip.cpp Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * ci: disable macos * ci: Fix workflows mostly Note we also updated vcpkg * ci: CodeRabbit suggestions * ci: Fix comment [ci skip] * ci: revert Coderabbit suggestion [ci skip] --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go back to Catch 2