Correct and validate JsonSchema for Ipv4Network, Ipv6Network, and IpNetwork #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
This corrects the
JsonSchemaimpl forIpv4Network,Ipv6Network, andIpNetwork. It uses thedoes-it-jsoncrate to validate that the schemas and serialization match. There's a little bit of extra niceness in the schemas:x-rust-typeextension so that code generators can substitute in theipnetwork::*IpNetworkincludes labels for the twooneOfschema variants in order to let code generators produce nicer codeNeither of these is strictly necessary. I can remove them if desired, but I think they add an extra degree of polish