fix: always return uint8arrays #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.1.0 incorporated internal refactors to use node `Buffer`s where possible to increase performance when `alloc`ing new byte arrays. It then returns those `Buffer`s but the problem is `Buffer` is not completely compatible with `Uint8Array` as some methods with the same name behave differently. We can convert a `Buffer` to a `Uint8Array` without copying it by using the 3-arg `Uint8Array` constructor so we should do that to retain the performance characteristics of `Buffer` when `alloc`ing but the compatibility of returning vanilla `Uint8Array`s.
Codecov ReportBase: 95.38% // Head: 95.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 95.38% 95.00% -0.39%
==========================================
Files 8 9 +1
Lines 260 280 +20
Branches 51 54 +3
==========================================
+ Hits 248 266 +18
- Misses 12 14 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hugomrdias
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.0 incorporated internal refactors to use node
Buffers where possible to increase performance whenallocing new byte arrays.It then returns those
Buffers but the problem isBufferis not completely compatible withUint8Arrayas some methods with the same name behave differently.We can convert a
Bufferto aUint8Arraywithout copying it by using the 3-argUint8Arrayconstructor so we should do that to retain the performance characteristics ofBufferwhenallocing but the compatibility of returning vanillaUint8Arrays at the cost of a performance hit toUint8Arrays.allocUnsafe(see the addedalloc.jsbenchmark).Before:
After:
Fixes #38