-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker run
option
#91
Conversation
Signed-off-by: Fred Tupas <fred.tupas21@gmail.com>
For now we build it locally but I think docker hub needs to be setup in order to
|
49142b4
to
d7a7445
Compare
Signed-off-by: Fred Tupas <fred.tupas21@gmail.com>
d7a7445
to
3260378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, what's the reason for different images for runtime vs building?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
primarily for separation of concerns but also for efficiency and maintainability, bonus is you have a smaller image size
here's a great reference https://docs.docker.com/build/building/multi-stage/
COPY --chmod=755 --from=builder /app/target/release/rainfrog /usr/local/bin/rainfrog | ||
|
||
# Change ownership of the files to the non-root user | ||
RUN chown -R rainfrog:rainfrog /usr/src/app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the binary is in /usr/local/bin, does this chown do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, updated it
Signed-off-by: Fred Tupas <fred.tupas21@gmail.com>
thanks for tackling this; it looks good, once the tests run i'll merge it and then set up dockerhub / change the readme in a follow up pr. |
Included in release v0.2.3 |
This pr does the following:
rainfrog
binarydocker run
option #89