Fix display string concatenation for array columns #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2024 16:14
… was rendered "abc", now "{a, b, c}")
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the vec_to_string function in src/database.rs to improve the display of array columns in the results pane.
- Changed array formatting from concatenated string "abc" to "{a, b, c}" for better readability
- Implemented curly braces and comma separators for array elements in
vec_to_stringfunction - Addresses issue array display may be unclear #97 regarding unclear array display in query results
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
|
thx for the pr @iwer ! it looks good, the greptile feedback doesn't seem too important so i'll merge once the tests finish |
|
Included in release v0.2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An array ["a", "b", "c"] was rendered "abc" in the results pane, now "{a, b, c}"
(May not be the most idiomatic rust)
closes #97