Handles Maneuver-only loads, improve regression testing #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuhone
reviewed
Oct 10, 2020
| @@ -263,6 +263,10 @@ def __init__(self, interrupt=False, backstop_file=None, nlet_file=None, | |||
| self.tstart = rev_bs_cmds[0]['time'] | |||
| self.tstop = rev_bs_cmds[-1]['time'] | |||
|
|
|||
| # Initialize the end time attribute for event searches within the BSC object | |||
| # At the beginning, it will be the time of the last command in the Review Load | |||
| self.BSC.end_event_time = rev_bs_cmds[-1]['time'] | |||
There was a problem hiding this comment.
Ideally we'd have this as a setting function (e.g. self.BSC.set_end_event_time(rev_bs_cmds[-1]['time']) instead of just setting the attribute, but we can worry about that later.
jzuhone
approved these changes
Oct 10, 2020
…tputs to and make that directory structure a bit saner
jzuhone
changed the title
jzuhone
changed the title
This was referenced Oct 19, 2020
Merged
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a required update to
acis_thermal_checkto work with the updates in acisops/backstop_history#13.The ACIS state builder records the end date of the review load in an attribute.
It also improves the regression testing framework to allow for different NLET files in the tests, as well as allow the user to specify a directory where the test artifacts (e.g.
states.dat,temperatures.dat) should be dumped. By default, these are dumped to a temporary directory, but the location can now be specified for later inspection.Testing