-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let 2-CCD (S3+FI) observations with less than 300 counts in the sequence go to -109 C #49
Conversation
@taldcroft since this fixes a bug as well as implements the 2-CCD "hot ACIS" observations which MP is already using, I'd like to get this into the next skare3 release. ACIS Ops will review, merge, and tag very soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi John,
I think it looks good. Because we only care about counts when there is no grating, I believe this is OK, but (as we discussed at the tag-up) I think the EST_CNT_RATE is only capturing the 0th order for grating observations, and not the 1st order. But this doesn't have bearing on the IDing etc so is a very minor thing.
-Jack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This PR enables the checking of 2-CCD observations (S3+FI) with less than 300 counts in the sequence which are allowed to go to -109 C. It does so by expanding the definition of -109 C-capable observations (i.e., leaving open the possibility that S3-only observations would still occur).
On the web page for the focal plane model, expanded information about the "hot ACIS" observations is now reported, and the same observations are also marked with a different color on the thermal plots.
Example:
https://cxc.cfa.harvard.edu/acis/Thermal/tests/fptemp_mar2122/
This also fixes a bug I uncovered in the process of preparing this PR that relates to the counting of all of the obsids in the sequence.
Interface impacts
The web pages now have expanded human-readable information about hot ACIS observations.
Testing
Unit tests
Functional tests
Several loads were hand-checked to make sure that the correct observations were marked as -109 C-capable.