Improve handling of vehicle loads in SimulateECSRun, other small changes #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SimulateECSRun
has handling to simulate a LTECS run for vehicle loads, but unfortunately it does not handle the case where the run begins during one vehicle load and continues into the following load (also vehicle-only). The simplest solution to this problem is to usekadi
to obtain the commanded states for vehicle loads. This will simply grab all of the commanded attitudes that have been entered into the database, which occurs shortly after loads are approved. The code will print to the log what loads were used in constructing the states.There is an interface impact as a result of these code changes (see below).
This PR also removes the code specific to the focal plane model that checked violations of the science data quality limits during a LTECS measurement--this is largely beside the point these days. For that reason we no longer need to specify the "instrument" when running the model for the ACIS FP.
Interface impacts
The accepted value to use for specifying the vehicle load option to the
attitude
argument inSimulateECSRun
has changed. Previously, one gave as the value the name of the load to take the commands from. Now, to specify vehicle commands, simply specify"vehicle"
as the argument.Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
Ran the command line version (
simulate_ecs_run
) using the same conditions as the recent LTECS run on 2024:160.