Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of vehicle loads in SimulateECSRun, other small changes #13

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jun 10, 2024

Description

SimulateECSRun has handling to simulate a LTECS run for vehicle loads, but unfortunately it does not handle the case where the run begins during one vehicle load and continues into the following load (also vehicle-only). The simplest solution to this problem is to use kadi to obtain the commanded states for vehicle loads. This will simply grab all of the commanded attitudes that have been entered into the database, which occurs shortly after loads are approved. The code will print to the log what loads were used in constructing the states.

There is an interface impact as a result of these code changes (see below).

This PR also removes the code specific to the focal plane model that checked violations of the science data quality limits during a LTECS measurement--this is largely beside the point these days. For that reason we no longer need to specify the "instrument" when running the model for the ACIS FP.

Interface impacts

The accepted value to use for specifying the vehicle load option to the attitude argument in SimulateECSRun has changed. Previously, one gave as the value the name of the load to take the commands from. Now, to specify vehicle commands, simply specify "vehicle" as the argument.

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Ran the command line version (simulate_ecs_run) using the same conditions as the recent LTECS run on 2024:160.

@jzuhone jzuhone requested review from Gregg140 and jazan12 June 10, 2024 01:35
Copy link

@jazan12 jazan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Copy link

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@jzuhone jzuhone merged commit a3639c3 into acisops:master Jun 11, 2024
@jzuhone jzuhone deleted the vehicle_load_improve branch June 11, 2024 16:38
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants