fix: explicitly enable curly in configs that include prettier
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2023
## [3.2.1](v3.2.0...v3.2.1) (2023-10-22) ### Bug Fixes * explicitly enable `curly` in configs that include `prettier` ([#293](#293)) ([496a4fa](496a4fa))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curlyis disabled byeslint-config-prettieras some of its configuration can conflict with Prettier; we enable it in our standard config in a way that is compatible but it's not in our tech-specific configs that do extend fromeslint-config-prettier- since these configs are meant to come after our standard config,curlyends up getting completely disabled.Because of how rules and configs currently work the main way to address this is by explicitly enabling the rule in each config - even though technically this rule isn't specific to the technologies each config is about, it's completely autofixable and I think it's reasonable to assume they'll be used with our standard config so I've gone with that.
This should not be needed once ESLint moves to using flat configs because we can just filter this rule out when importing
eslint-config-prettier.