Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow v7 of @typescript-eslint and v28 of eslint-plugin-jest #321

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: allow v7 of @typescript-eslint and v28 of eslint-plugin-jest #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c78fc86
feat: allow `@typescript-eslint` v7
G-Rath May 8, 2024
640abdb
feat: allow `eslint-plugin-jest` v28
G-Rath May 8, 2024
2311f19
ci: test against new peer dependencies
G-Rath May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,17 @@ jobs:
permissions:
contents: read # to fetch code (actions/checkout)
# prettier-ignore
name: Lint on ${{ matrix.os }} with eslint v${{ matrix.eslint }}, using Node.js LTS
name: Lint on ${{ matrix.os }} with eslint v${{ matrix.eslint }}, @typescript-eslint v${{ matrix.typescript-eslint }}, eslint-plugin-jest v${{ matrix.jest-eslint }}, and using Node.js LTS
strategy:
fail-fast: false
matrix:
eslint: [7, 8]
typescript-eslint: [6, 7]
jest-eslint: [27, 28]
os: [ubuntu-latest, macOS-latest]
exclude:
- eslint: 7
typescript-eslint: 7
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand All @@ -70,7 +75,8 @@ jobs:
cache: npm

- run: npm ci
- run: npm install eslint@${{ matrix.eslint }} --no-fund
# prettier-ignore
- run: npm install eslint@${{ matrix.eslint }} @typescript-eslint/parser@${{ matrix.typescript-eslint }} @typescript-eslint/eslint-plugin@${{ matrix.typescript-eslint }} eslint-plugin-jest@${{ matrix.jest-eslint }} --no-fund
- run: npm run lint
test:
permissions:
Expand Down Expand Up @@ -112,3 +118,4 @@ jobs:

- run: npm ci
- run: npm run typecheck

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,13 @@
},
"peerDependencies": {
"@babel/eslint-parser": "^7.0.0",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"@typescript-eslint/eslint-plugin": "^6.0.0 || ^7.0.0",
"@typescript-eslint/parser": "^6.0.0 || ^7.0.0",
"eslint": ">= 7.0",
"eslint-plugin-eslint-comments": ">= 3",
"eslint-plugin-flowtype": "^8.0.0",
"eslint-plugin-import": ">= 2.21",
"eslint-plugin-jest": "^27.0.0",
"eslint-plugin-jest": "^27.0.0 || ^28.0.0",
"eslint-plugin-jest-formatting": "^3.0.0",
"eslint-plugin-jsx-a11y": "^6.0.0",
"eslint-plugin-node": ">= 2.21",
Expand Down