Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update releases and contributing sections #345

Merged
merged 3 commits into from
Nov 11, 2024
Merged

docs: update releases and contributing sections #345

merged 3 commits into from
Nov 11, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 10, 2024

While working on other stuff I realised these sections have some silly mistakes and still mention Semantic Pull Request which we've not used in a while so I decided to clean them up

@G-Rath G-Rath changed the title docs: update contributing section to reflect that we no longer use Semantic Pull Request docs: update contributing section to reflect that we no longer use SPR Nov 10, 2024
@G-Rath G-Rath changed the title docs: update contributing section to reflect that we no longer use SPR docs: update releases and contributing sections Nov 10, 2024
Copy link

@nzlaura nzlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small note 😅

README.md Outdated
When making a PR, `Semantic Pull Request` will check if the PR will trigger a
release, based on the title & commits in the PR.
As we squash our pull requests when merging by default, you should ideally use
title your pull requests using the convectional commit format since that will be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: swap out convectional for conventional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gaahh I did it again somehow

@G-Rath G-Rath merged commit 3976af4 into main Nov 11, 2024
18 checks passed
@G-Rath G-Rath deleted the cleanup-docs branch November 11, 2024 23:41
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants