fix: ensure env doesn't get clobbered when installing package_json
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The remaining CI failures are due to #574 which I want to merge after this |
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
JacobBriggsAckama,
brooke-m,
hopkincame and
nzlaura
eoinkelly
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that something had changed in Ruby 3.3.6 that means for some reason unless we maintain the old env, the use of
bundler/inlinecauses Bundler to error about gems not being present when we (very) later callrun "bundle install".I have no idea what has actually changed, as while I confirmed everything is passing if we switch to Ruby 3.3.5, I couldn't get a smaller reproducible example that showed the exact same behaviour 🤷