-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestion: NEJLT 2023 #3720
Ingestion: NEJLT 2023 #3720
Conversation
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
LGTM, except that the full volume PDF doesn’t seem to be included? (The |
@anthology-assist can you comment here? What happened to the full volume PDF? |
data/xml/2023.nejlt.xml
Outdated
<publisher>Northern European Association of Language Technology</publisher> | ||
<address>Copenhagen, Denmark</address> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that this is a mistake that also needs to be corrected in previous issues; it should be:
<publisher>Linköping University Electronic Press</publisher>
<address>Linköping, Sweden</address>
(I could open a PR for previous issues.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to just fix these and add them to this PR?
I tried to run the ingestion myself locally, but I feel I’m missing something or don’t know which script to use, since I’m not getting the same XML file as here with Would be nice if full volume PDF could be added as well. I’m happy for pointers if there was something wrong in the ingestion material regarding that. |
Ack, I'm really sorry ingestion here came to a complete standstill. |
@mbollmann can you post the full-volume PDF somewhere (to this post, if possible), and I will ingest this? |
Here is the code that looks for book names: Line 291 in 586863a
It seems we need to add a new pattern. I just did that. We can fix this manually this time if I get the PDF. |
Full issue PDF: https://nejlt.ep.liu.se/issue/view/407/337 I can also update the name in the script that produces the materials of course, I have just been re-using what Leon used in previous years to produce these materials. :) |
LGTM now, thank you! |
master
branch<meta>
block<venue>ws</venue>
tag to its meta block<event>
block