Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_huaweicloud.sh minor bug fixes #3891

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Conversation

tutugreen
Copy link
Contributor

  1. 接口是模糊搜索,在账户添加了二级域名、相同结尾域名等情况下,会返回多条结果。
    在原脚本基础上增加对返回体判断,遍历取所需ZoneID。
    Fix Report bugs to HuaweiCloud DNS API #3265 (comment)

  2. 以 '"id"' 方式判断record是否存在,修复域名不能包含"id"的问题。
    Fix Report bugs to HuaweiCloud DNS API #3265 (comment)

(Actions 有 Log,就把 Access Token 的 _debug 注释了)

1. Match zone name in response in case multiple items return.
2. Use string '"id"' (single quotation marks added) to check if zone/record exist in _get_zoneid() & _get_recordset_id(). Fix domain can't contain string "id".

(Sensitive _debug Access Token Commented out, For CICD Run)
dnsapi/dns_huaweicloud.sh Outdated Show resolved Hide resolved
dnsapi/dns_huaweicloud.sh Outdated Show resolved Hide resolved
_secure_debug for sensitive token.
@Neilpang Neilpang merged commit c41de8f into acmesh-official:dev Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants