issue 3007 - fix base64 decoding logic for single- and multi-line encoded string #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks |
Djelibeybi
added a commit
to Djelibeybi/acme.sh
that referenced
this pull request
May 21, 2022
The change to _dbase64 made in acmesh-official#4057 broke the way OCI_CLI_KEY was decoded from the previously encoded file content. This fixes the decode by removing the multiline parameter. Signed-off-by: Avi Miller <avi.miller@oracle.com>
Djelibeybi
added a commit
to Djelibeybi/acme.sh
that referenced
this pull request
May 21, 2022
The change made in acmesh-official#4057 broke the decoding of OCI_CLI_KEY from the encoded OCI_CLI_KEY_FILE content so this removes the multiline parameter to fix it. Signed-off-by: Avi Miller <avi.miller@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3007
The parameters for
openssl base64 -din _dbase64() are wrong. When used with current version of openssl, its actualy working fine as far as i know but the parameters are wrong and in could cause other unexpected bugs or issues.More info in my comment: #3007 (comment)