Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dns_opnsense.sh error deleting record #4958

Closed
wants to merge 1 commit into from
Closed

fix dns_opnsense.sh error deleting record #4958

wants to merge 1 commit into from

Conversation

kanata3249
Copy link

This patch fixed dns_opnsense.sh error deleting record.

  • fix delRecord request body.
    removed unnecessary backslashs.
  • fix reconfigure after record deletion succeeded.
    parse _opns_rest '$response' instead of uninitilized '$_return_str'.

Copy link

Welcome
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@kanata3249 kanata3249 closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant