RouterOS - make deploy more resilient #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where importing the cert and key removes the files from disk the existing deploy will fail when it tries to remove those files. This still attempts to remove the files but catches the error and moves on instead of bombing like before. Similarly, if the deploy had failed before, subsequent deploys would fail because the script already existed, so it would not be able to create the script. This first attempts to remove the script if it exists, and then creates the script.
|
I haven't tested on my routers, but code change looks good. 👍 |
|
@cngarrison I don't have anything running 6.x unfortunately, but the two 7.x devices I tried it on worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer releases of RouterOS automatically delete the cert and key files from disk when importing the certs, and that means the existing deploy will fail when it tries to explicitly remove those files. This still attempts to remove the files but catches the error and moves on instead of bombing like before.
Similarly, if the deploy had failed before but the script was created, subsequent deploys would fail because the script already existed. This first attempts to remove the script if it exists, and then creates the script.
This has been tested on RouterOS 7.15.3 , but I assume this should be backwards compatible, and it's currently broken on later ROS versions for reasons mentioned above.