Small cleanup and adding two new options: --key-chown and --key-chmod #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2024 12:24
Both options have only an effect when used in combination with --key-file. Their purpose is to change owner/group and permission of copied key file. The arguments to the options have to follow the chown/chmod argument syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i added two new options to acme.sh:
--key-chown <owner[:group]>--key-chmod <perm>They only have an effect when used in combination with --key-file.
The purpose of them is to explicitly set the owner/group and file permission of the copied key file.
The arguments of them have to follow the chown/chmod argument syntax.
Example usage (for Debian systems):
acme.sh --install-cert --domain example.com --key-file /etc/ssl/private/example.com.key --key-chown "root:ssl-cert" --key-chmod "640" --fullchain-file /etc/ssl/certs/example.com.crt --reloadcmd "systemctl reload postfix apache2"I tested functionality of them with --install-cert, --issue and --renew.
Best regards,
Robert