add Nullish Coalescing #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
RReverser
reviewed
Dec 5, 2019
mysticatea
force-pushed
the
nullish-coalescing
branch
from
fc1515d to
3565751
Compare
Merged
mysticatea
force-pushed
the
nullish-coalescing
branch
from
3565751 to
92e7f20
Compare
KFlash
reviewed
Dec 9, 2019
mysticatea
force-pushed
the
nullish-coalescing
branch
from
93a4212 to
b0fc336
Compare
|
can this be merged? why the wait? |
This was referenced Feb 19, 2020
Closed
2 tasks
Merged
|
Yay, estree/estree#204 got split into two and the uncontroversial nullish coalescing part got split out into estree/estree#211 - which as been merged, so I thiiink this is unblocked from the ESTree spec side |
|
Wonderful. Shall I tag a release, on the assumption that optional chaining is going to take a while more? |
30 tasks
|
@marijnh That would be wonderful! |
|
I've released 7.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new syntax Nullish Coalescing (
??operator).Please mind the ESTree spec is on discussing. It might changes.
As a side effect, this PR adds a parameter to theThis PR no longer adds any parameters.parseExprOpmethod. The parameter is used to raise the syntax error of mixed short-circuit expressions. If a plugin doesn't pass the new parameter, acorn doesn't raise the syntax error.