This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2023
3 tasks
nclack
reviewed
Jul 5, 2023
nclack
reviewed
Jul 5, 2023
nclack
reviewed
Jul 5, 2023
nclack
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
acquire-device-properties
: Astruct storage_properties_multiscale_s
membermultiscale
toStorageProperties
.acquire-device-properties
: A corresponding entry inStoragePropertyMetadata
.acquire-device-properties
: A convenience function for setting multiscale properties, similar to the function forsetting chunking properties.
Possible controversies
If anything is controversial, it'll probably be this one-member struct
At one point there were other members for strategy and downsample factor. I'm expecting that these could come back at some point in the future.