Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move playground.cpp to a sandbox module #48

Closed
aliddell opened this issue Jun 27, 2023 · 2 comments · Fixed by #281
Closed

Move playground.cpp to a sandbox module #48

aliddell opened this issue Jun 27, 2023 · 2 comments · Fixed by #281

Comments

@aliddell
Copy link
Member

We can't build tests on unsupported platforms because they require EGrabber.h. We can add the NOTEST flag when we configure in order to get around this, but we could also just set NOTEST=1 when we can't find the EGrabber library.

@nclack
Copy link
Member

nclack commented Jun 30, 2023

there's really just one test that needs egrabber.h. It's the "playground". One option is to remove it, since it's not a real test. Another option is to qualify it in the cmake so it only attempts to build if egrabber is found.

In principle, the integration tests shouldn't depend on "egrabber.h", imo.

@aliddell
Copy link
Member Author

I'm generally in favor of putting things like that in a sandbox module that you have to turn on behind a CMake flag. Happy to do this if that's the way you want to take it.

@aliddell aliddell changed the title Unsupported platform builds shouldn't need to manually specify -DNOTEST=1 Move playground.cpp to a sandbox module Apr 2, 2024
nclack pushed a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants