238, part 2: Misc fixes #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliddell
force-pushed
the
238-implement-s3-sinks-pt-2
branch
4 times, most recently
from
fa870a2
to
932407a
Compare
aliddell
force-pushed
the
238-implement-s3-sinks-pt-2
branch
from
932407a
to
13ce335
Compare
shlomnissan
approved these changes
Jul 8, 2024
| @@ -12,7 +12,7 @@ | |||
| #include <fstream> | |||
| #include <stdexcept> | |||
|
|
|||
| #include "tests/json.hpp" | |||
| #include <nlohmann/json.hpp> | |||
There was a problem hiding this comment.
I think we can delete tests/json.hpp at this point, right?
There was a problem hiding this comment.
I think you did this already in an earlier PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the x64-osx triplet for build and release jobs on Mac (see error here)lol never mind, here's an issue to address in a separate PR