-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #125
Update README.md #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a few suggestions. I really appreciate this update, it looks great.
README.md
Outdated
Acquire also supports the following output file formats: | ||
|
||
- [Tiff](https://en.wikipedia.org/wiki/TIFF) | ||
- [Zarr](https://zarr.dev/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should mention this is OME-Zarr (for zarr v2) and Zarr v3.
README.md
Outdated
- [Tiff](https://en.wikipedia.org/wiki/TIFF) | ||
- [Zarr](https://zarr.dev/) | ||
|
||
For testing and demonstration purposes, Acquire provides a few simulated cameras, as well as raw and trash output devices. | ||
|
||
## Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about moving the install instructions to the very top of the README? This may help clarify the acquire-imaging
awkwardness.
Co-authored-by: Nathan Clack <nclack@gmail.com>
Thanks for the feedback, @nclack! I've updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more change :)
README.md
Outdated
|
||
This python package provides a multi-camera video streaming library focusing | ||
on performant microscopy. | ||
### Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Installation | |
### Installation |
Lets just get rid of the heading. Alternatively could add an About
heading before line 14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks better with Installation deleted than with having both Installation and About headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Updating the README with copy from docs website and providing a link to the documentation.