Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #125

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Update README.md #125

merged 4 commits into from
Dec 4, 2023

Conversation

dgmccart
Copy link
Collaborator

@dgmccart dgmccart commented Dec 4, 2023

Updating the README with copy from docs website and providing a link to the documentation.

Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a few suggestions. I really appreciate this update, it looks great.

README.md Outdated Show resolved Hide resolved
README.md Outdated
Acquire also supports the following output file formats:

- [Tiff](https://en.wikipedia.org/wiki/TIFF)
- [Zarr](https://zarr.dev/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mention this is OME-Zarr (for zarr v2) and Zarr v3.

README.md Outdated
- [Tiff](https://en.wikipedia.org/wiki/TIFF)
- [Zarr](https://zarr.dev/)

For testing and demonstration purposes, Acquire provides a few simulated cameras, as well as raw and trash output devices.

## Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving the install instructions to the very top of the README? This may help clarify the acquire-imaging awkwardness.

dgmccart and others added 2 commits December 4, 2023 13:24
Co-authored-by: Nathan Clack <nclack@gmail.com>
@dgmccart
Copy link
Collaborator Author

dgmccart commented Dec 4, 2023

Thanks for the feedback, @nclack! I've updated the PR.

Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more change :)

README.md Outdated

This python package provides a multi-camera video streaming library focusing
on performant microscopy.
### Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Installation
### Installation

Lets just get rid of the heading. Alternatively could add an About heading before line 14.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks better with Installation deleted than with having both Installation and About headings

Copy link
Member

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nclack nclack merged commit 832233a into acquire-project:main Dec 4, 2023
20 checks passed
@dgmccart dgmccart deleted the patch-2 branch December 4, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants