Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include __version__ at runtime #176

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

tlambert03
Copy link
Contributor

This PR adds a __version__ attribute to the top level module

@aliddell
Copy link
Member

aliddell commented Mar 7, 2024

@tlambert03 can we get a test?

@aliddell
Copy link
Member

aliddell commented Mar 7, 2024

Getting

  Error: fatal: No url found for submodule path 'acquire-docs' in .gitmodules
  Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128

in the tests. We don't need acquire-docs for this one, do we?

@tlambert03
Copy link
Contributor Author

We don't need acquire-docs for this one, do we?

oops 😂 my bad sorry will remove. didn't notice that made it in

@tlambert03
Copy link
Contributor Author

ok, removed and removed the accidental formatting in tests

Copy link
Member

@aliddell aliddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aliddell aliddell merged commit 23a3edd into acquire-project:main Mar 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants