Skip to content

Updates to ERC 7683

Updates to ERC 7683 #5

Triggered via pull request September 30, 2024 21:02
Status Failure
Total duration 9m 25s
Artifacts 1

ci.yml

on: pull_request
Save PR Number
2s
Save PR Number
HTMLProofer
8m 58s
HTMLProofer
Link Check
22s
Link Check
CodeSpell
14s
CodeSpell
EIP Walidator
8s
EIP Walidator
Markdown Linter
5s
Markdown Linter
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 8 warnings
Markdown Linter
Process completed with exit code 1.
Markdown Linter
Unable to process file command 'env' successfully.
Markdown Linter
Invalid value. Matching delimiter not found 'EOF'
the first match of the given pattern must be a link: ERCS/erc-7683.md#L35
error[markdown-link-first]: the first match of the given pattern must be a link --> ERCS/erc-7683.md | 35 | - **User**: for the purposes of this document, the user is the end-user who is sending the ERC-7683 order. | = info: the pattern in question: `(?i)(?:eip|erc)-[0-9]+` = help: see https://ethereum.github.io/eipw/markdown-link-first/
body has extra section(s): ERCS/erc-7683.md#L283
error[markdown-order-section]: body has extra section(s) --> ERCS/erc-7683.md | 283 | ## Examples | = help: see https://ethereum.github.io/eipw/markdown-order-section/
proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`): ERCS/erc-7683.md#L338
error[markdown-re-eip-dash]: proposals must be referenced with the form `EIP-N` (not `EIPN` or `EIP N`) --> ERCS/erc-7683.md | 338 | In this example, the Message sub-type allows the user to delegate destination chain contract execution to fillers. However, because transactions are executed via filler, the `msg.sender` would be the `DestinationSettler`, making this `Message` sub-type limited if the target contract authenticates based on the `msg.sender`. Ideally, 7683 orders containing Messages can be combined with smart contract wallets like implementations of [ERC4337](https://github.com/across-protocol/ERCs/blob/master/ERCS/erc-4337.md) or [EIP7702](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md) to allow complete cross-chain delegated execution. | = info: the pattern in question: `(?i)eip[\s]*[0-9]+` = help: see https://ethereum.github.io/eipw/markdown-re-eip-dash/
proposals must be referenced with the form `ERC-N` (not `ERCN` or `ERC N`): ERCS/erc-7683.md#L338
error[markdown-re-erc-dash]: proposals must be referenced with the form `ERC-N` (not `ERCN` or `ERC N`) --> ERCS/erc-7683.md | 338 | In this example, the Message sub-type allows the user to delegate destination chain contract execution to fillers. However, because transactions are executed via filler, the `msg.sender` would be the `DestinationSettler`, making this `Message` sub-type limited if the target contract authenticates based on the `msg.sender`. Ideally, 7683 orders containing Messages can be combined with smart contract wallets like implementations of [ERC4337](https://github.com/across-protocol/ERCs/blob/master/ERCS/erc-4337.md) or [EIP7702](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md) to allow complete cross-chain delegated execution. | = info: the pattern in question: `(?i)erc[\s]*[0-9]+` = help: see https://ethereum.github.io/eipw/markdown-re-erc-dash/
proposals must be referenced with the form `ERC-N` (not `ERCN` or `ERC N`): ERCS/erc-7683.md#L369
error[markdown-re-erc-dash]: proposals must be referenced with the form `ERC-N` (not `ERCN` or `ERC N`) --> ERCS/erc-7683.md | 369 | This design decision is motivated by the existence of many viable cross-chain messaging systems today offering settlement contracts a variety of tradeoffs. We hope that ERC7683 can eventually support an ERC dedicated to standardizing a safe, trustless, cross-chain verification system. | = info: the pattern in question: `(?i)erc[\s]*[0-9]+`
non-relative link or image: ERCS/erc-7683.md#L338
error[markdown-rel-links]: non-relative link or image --> ERCS/erc-7683.md | 338 | In this example, the Message sub-type allows the user to delegate destination chain contract execution to fillers. However, because transactions are executed via filler, the `msg.sender` would be the `DestinationSettler`, making this `Message` sub-type limited if the target contract authenticates based on the `msg.sender`. Ideally, 7683 orders containing Messages can be combined with smart contract wallets like implementations of [ERC4337](https://github.com/across-protocol/ERCs/blob/master/ERCS/erc-4337.md) or [EIP7702](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md) to allow complete cross-chain delegated execution. | = help: see https://ethereum.github.io/eipw/markdown-rel-links/
non-relative link or image: ERCS/erc-7683.md#L338
error[markdown-rel-links]: non-relative link or image --> ERCS/erc-7683.md | 338 | In this example, the Message sub-type allows the user to delegate destination chain contract execution to fillers. However, because transactions are executed via filler, the `msg.sender` would be the `DestinationSettler`, making this `Message` sub-type limited if the target contract authenticates based on the `msg.sender`. Ideally, 7683 orders containing Messages can be combined with smart contract wallets like implementations of [ERC4337](https://github.com/across-protocol/ERCs/blob/master/ERCS/erc-4337.md) or [EIP7702](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md) to allow complete cross-chain delegated execution. |
EIP Walidator
validation found errors :(
Save PR Number
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@65d862660abb392b8c4a3d1195a2108db131dd05. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Markdown Linter
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
EIP Walidator
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn`: ERCS/erc-7683.md#L371
warning[markdown-html-comments]: HTML comments are only allowed while `status` is one of: `Draft`, `Withdrawn` --> ERCS/erc-7683.md | 371 | <!-- TODO --> | = help: see https://ethereum.github.io/eipw/markdown-html-comments/
CodeSpell
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Link Check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@47fbe2df0ad0e27efb67a70beac3555f192b062f. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
HTMLProofer
The following actions use a deprecated Node.js version and will be forced to run on node20: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "pr_number". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
pr_number
84 Bytes